Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Update Serialize javascript module #908

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 18, 2025

What was done

  • Updated CKEditor 5 to 44 and CKEditor 5 dev utils to 46.
  • Converted the webpack configuration file from CommonJS to ES Module.
    • Fixed DllReferencePlugin require() issue.
    • Handled CKEditorTranslationsPlugin correctly
    • Updated NonCKEPluginEntries() to return an object instead of using map().

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_serialize_javascript
  • Run make drush-updb drush-cr

How to test

  • Open your terminal and go to ./public/modules/contrib/helfi_platform_config/modules/helfi_ckeditor/
    • Run nvm use && npm i && npm run build and check that the builder works. None of the plugins minified files should change.
  • Check that the tests pass
  • Check that code follows our standards

…Fixed DllReferencePlugin require() issue. Handled CKEditorTranslationsPlugin correctly and Updated NonCKEPluginEntries() to return an object instead of using map().
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants