Skip to content

Commit

Permalink
Merge pull request #240 from City-of-Helsinki/update-pr-template
Browse files Browse the repository at this point in the history
Update PR tempalte
  • Loading branch information
matti-lamppu authored Mar 6, 2023
2 parents 8c90533 + b002596 commit 1ee1a36
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,20 @@

## Pull request checklist

Check the boxes for each DoD items that has been completed:

- **Frontend**
- [ ] Changes have been tested
- **Backend**
- [ ] Changes have been tested
- [ ] Automatic tests has been added
- [ ] OpenAPI definitions have been updated
- [ ] Database migrations will work in test environment
- [ ] Oracle migration has been updated
- [ ] initial.json has been updated to work with migrations
Check the boxes for each DoD item that has been completed:

- **Testing**
- [ ] Changes have been tested
- [ ] Automatic tests have been added
- **Database**
- [ ] Database migrations will work in the DEV & TEST environments
- [ ] initial.json has been updated to work with migrations
- [ ] Oracle migration has been updated
- **Documentation**
- [ ] Tooltips have been added in the frontend for all new fields
- [ ] OpenAPI definitions have been updated
- [ ] Test instructions have been written for the customer in the appropriate ticket in Jira
- [ ] Terminology page in Confluence has been updated

## Test plan

Expand Down

0 comments on commit 1ee1a36

Please sign in to comment.