Keyless Entry Emails #1558
Closed
Keyless Entry Emails #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranta
added
refactor
backend/tilavarauspalvelu/api/graphql/types/reservation/serializers/approve_serializers.py
Outdated
Show resolved
Hide resolved
matti-lamppu
requested changes
Feb 13, 2025
ranta
force-pushed
the
keyless-emails
branch
2 times, most recently
from
4ead8f7 to
e0c6e14
Compare
matti-lamppu
approved these changes
Feb 17, 2025
ranta
force-pushed
the
keyless-emails
branch
2 times, most recently
from
0d98a75 to
df0178b
Compare
ranta
force-pushed
the
keyless-emails
branch
from
df0178b to
8a6849a
Compare
- Not all translations in the context are used in every email, but that's fine
- List required fields in the class - Use the list for creating tester forms and getting mock context data
- Suppress ExternalServiceError instead of PindoraClientError
ranta
force-pushed
the
keyless-emails
branch
from
8a6849a to
6bfe83b
Compare
|
|
Merged to #1591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
EmailTypeand contexts🧪 Test plan
🚧 Dependencies
🎫 Tickets