Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pindora service & fix Pindora integration issues #1613

Merged
merged 9 commits into from
Mar 3, 2025
Merged

Add Pindora service & fix Pindora integration issues #1613

merged 9 commits into from
Mar 3, 2025

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Feb 28, 2025 •
edited
Loading

🛠️ Changelog

  • Add a service class for Pindora to simplify Pindora operations
  • Fix caching for reschedule operations
  • Fix reservation unit admin panel submit not working with null begin date in access type

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu matti-lamppu self-assigned this Feb 28, 2025
@matti-lamppu matti-lamppu added improvement Improves an existing feature feature Adds a new feature labels Feb 28, 2025
@matti-lamppu matti-lamppu changed the title Add Pindora service Add Pindora service & fix issues Feb 28, 2025
@matti-lamppu matti-lamppu changed the title Add Pindora service & fix issues Add Pindora service & fix Pindora integration issues Feb 28, 2025
@matti-lamppu matti-lamppu marked this pull request as ready for review February 28, 2025 13:00
ranta
ranta approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@ranta ranta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some good stuff 🚀 Love how much code was able to be removed everywhere and concentrated into the service class 😁
Also the commits were split up nicely for easy readability ❤️

@matti-lamppu matti-lamppu force-pushed the add-pindora-service branch from 485bf9b to de48598 Compare March 3, 2025 08:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@matti-lamppu
Copy link
Collaborator Author

/ff

@github-actions github-actions bot merged commit de48598 into main Mar 3, 2025
20 of 21 checks passed
@github-actions github-actions bot deleted the add-pindora-service branch March 3, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama approved these changes

@ranta ranta ranta approved these changes

Assignees

@matti-lamppu matti-lamppu

Labels
feature Adds a new feature improvement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matti-lamppu @vergama @ranta