chore: remove old comission-based effect

City-of-Helsinki · Apr 3, 2024 · 0777ba6 · 0777ba6
1 parent e3b26b4
commit 0777ba6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/...it/applicant/src/components/applications/forms/application/step2/ApplicationFormStep2.tsx b/...it/applicant/src/components/applications/forms/application/step2/ApplicationFormStep2.tsx
@@ -60,8 +60,6 @@ const ApplicationFormStep2: React.FC<DynamicFormStepComponentProps> = ({
 
   useDependentFieldsEffect(
     {
-      apprenticeshipProgram: formik.values.apprenticeshipProgram,
-      benefitType: formik.values.benefitType,
       paySubsidyGranted: formik.values.paySubsidyGranted,
       associationHasBusinessActivities:
         formik.values.associationHasBusinessActivities,

diff --git a/frontend/benefit/applicant/src/hooks/useDependentFieldsEffect.ts b/frontend/benefit/applicant/src/hooks/useDependentFieldsEffect.ts
@@ -1,10 +1,8 @@
-import { BENEFIT_TYPES, PAY_SUBSIDY_GRANTED } from 'benefit-shared/constants';
+import { PAY_SUBSIDY_GRANTED } from 'benefit-shared/constants';
 import React from 'react';
 
 interface FieldValues {
   useAlternativeAddress?: boolean | null;
-  apprenticeshipProgram?: boolean | null;
-  benefitType?: BENEFIT_TYPES | '';
   paySubsidyGranted?: PAY_SUBSIDY_GRANTED | null;
   associationHasBusinessActivities?: boolean | null;
   startDate?: string;
@@ -46,8 +44,6 @@ type State = EFFECTS[];
 export const useDependentFieldsEffect = (
   {
     useAlternativeAddress,
-    apprenticeshipProgram,
-    benefitType,
     paySubsidyGranted,
     associationHasBusinessActivities,
     startDate,
@@ -119,13 +115,6 @@ export const useDependentFieldsEffect = (
     }
   }, [paySubsidyGranted]);
 
-  // Effects when apprenticeshipProgram changes
-  React.useEffect(() => {
-    if (benefitType === BENEFIT_TYPES.COMMISSION && apprenticeshipProgram) {
-      dispatch(createUpdateAction([EFFECTS.CLEAR_BENEFIT_VALUES]));
-    }
-  }, [apprenticeshipProgram, benefitType]);
-
   // Effects when associationHasBusinessActivities changes
   React.useEffect(() => {
     if (associationHasBusinessActivities === false) {