Define order of returned routed centreline links #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordered by sequence in the routed path, as returned by pgrouting
gabrielwol
requested changes
Jan 6, 2025
| array_agg(routing_centreline_directional.centreline_id), | ||
| st_union(st_linemerge(routing_centreline_directional.geom)) AS geom | ||
| array_agg(routing_centreline_directional.centreline_id ORDER BY path_seq), | ||
| st_union(st_linemerge(routing_centreline_directional.geom ORDER BY path_seq)) AS geom |
There was a problem hiding this comment.
I get this error while testing:
ERROR: ORDER BY specified, but st_linemerge is not an aggregate function
Need to remove the order by in this line.
There was a problem hiding this comment.
Oops! That should be one parenthesis out, within ST_Union.
Though now that I think about it, I'm not certain that multigeometries actually preserve order. It would be preferable to order the sub-geometries too if possible.
|
Fixed! From a quick test, it does appear that order is preserved within the multi-geometries, making the link IDs and geometries accessible as pairs with an unnest/st_dump combo. |
gabrielwol
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
Issue(s) this solves:
gis_core.get_centreline_btwn_intersectionsshould return links in routed order #1126What, in particular, needs to reviewed:
Since the order was previously undefined, it shouldn't break anything to specify it now.
What needs to be done by a sysadmin after this PR is merged