Skip to content

Commit

Permalink
tc_build/binutils: Move TemporaryDirectory() usage inside a with block
Browse files Browse the repository at this point in the history
To satisfy pylint.

Fixes:
tc_build/binutils.py:34:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

Signed-off-by: Dakkshesh <dakkshesh5@gmail.com>
  • Loading branch information
dakkshesh07 committed Jan 29, 2025
1 parent 9f0db9d commit 598c9fe
Showing 1 changed file with 17 additions and 14 deletions.
31 changes: 17 additions & 14 deletions tc_build/binutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,23 @@ def build(self):
self.folders.build.mkdir(exist_ok=True, parents=True)
tc_build.utils.print_header(f"Building {self.target} binutils")

configure_cmd = [
Path(self.folders.source, 'configure'),
*self.configure_flags,
] + [f"{var}={val}" for var, val in self.configure_vars.items()]
self.run_cmd(configure_cmd, cwd=self.folders.build)

make_cmd = ['make', '-C', self.folders.build, '-s', f"-j{os.cpu_count()}", 'V=0']
self.run_cmd(make_cmd)

if self.folders.install:
self.run_cmd([*make_cmd, 'install'])
tc_build.utils.create_gitignore(self.folders.install)
# Clean temporary dir containing docs after installing
self.tmpdir.cleanup()
# Redirect unwanted docs to a temporary dir
with TemporaryDirectory() as tmpdir:
doc_dirs = ['infodir', 'htmldir', 'pdfdir', 'mandir']
self.configure_flags += [f"--{d}={tmpdir}" for d in doc_dirs]

configure_cmd = [
Path(self.folders.source, 'configure'),
*self.configure_flags,
] + [f"{var}={val}" for var, val in self.configure_vars.items()]
self.run_cmd(configure_cmd, cwd=self.folders.build)

make_cmd = ['make', '-C', self.folders.build, '-s', f"-j{os.cpu_count()}", 'V=0']
self.run_cmd(make_cmd)

if self.folders.install:
self.run_cmd([*make_cmd, 'install'])
tc_build.utils.create_gitignore(self.folders.install)


class StandardBinutilsBuilder(BinutilsBuilder):
Expand Down

0 comments on commit 598c9fe

Please sign in to comment.