security: update the SSO process #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After receiving a privsec breach report, we updated our SSO process. This fixes the main issues: - Add-on APIs using the example password and sso_salt from this documentation - The `token` is not signing all the fields that we send to the SSO URL. You can impersonate a user by using their email. The email has never be documented as a secure identification method, but some providers used it anyway. It’s best to acknowledge the breach and sign the whole body.
👋` Review app deletedYou closed this PR and deleted the review app. |
davlgd
temporarily deployed
to
PR review apps
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After receiving a privsec breach report, we updated our SSO process. This fixes the main issues:
tokenis not signing all the fields that we send to the SSO URL. You can impersonate a user by using their email.The email has never be documented as a secure identification method, but some providers used it anyway. It’s best to acknowledge the breach and sign the whole body.
Checklist
Reviewers
@ssauvin