Make number of NetCDF points YAML controllable #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
approved these changes
Jan 29, 2024
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
2 times, most recently
from
76ea84a to
cf49041
Compare
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
from
cf49041 to
d5b82a6
Compare
I added one example for a single column where I also show that we cannot specify 1 point (it has to be at least 2). It has to be at least 2 because of how ranges work in Julia. They hare inclusive of the extremes and ill-defined when you only have one point. I could add some logic to handle this edge case, but I don't think it's worth doing it for the time being. |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to dispatch over the grid type (with CliMA/ClimaCore.jl#1567) to have more reasonable defaults.