Revamp and extend ClimaCore matrix data structures #1190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/matrix_structures
branch
from
9a4f18b to
8e2f330
Compare
dennisYatunin
force-pushed
the
dy/matrix_structures
branch
from
503bf12 to
c7980cd
Compare
There was a problem hiding this comment.
Can we:
- Write tests for this sketch that compare against a very simple Fortran-style array implementation, for a few core examples?
- Write additional unit tests that you believe are important to ensure the correctness, including edge and corner cases (and so that others can exercise this code for, e.g., performance analysis)
|
Would it be meaningful to have a simple integration test planned as well? Where we would solve some simpler set of coupled equations than the full EDMFX+dycore and test the implicit solver? We could use it to explain the concepts/abstractions that need to be implemented? I think it would help with documenting what is happening also |
dennisYatunin
force-pushed
the
dy/matrix_structures
branch
3 times, most recently
from
dd45f66 to
c94fa19
Compare
7 tasks
dennisYatunin
force-pushed
the
dy/matrix_structures
branch
from
05109a1 to
3c9ac01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a proper API for "columnwise band matrix fields" and "block matrices of matrix fields" to ClimaCore, along with unit tests and documentation. This will vastly simplify and extend the matrix data structures and operations that are currently spread across
ClimaCore.jl/src/Operators/stencilcoefs.jl,ClimaCore.jl/src/Operators/pointwisestencil.jl,ClimaCore.jl/src/Operators/operator2stencil.jl,ClimaAtmos.jl/src/tendencies/implicit/wfact.jl, andClimaAtmos.jl/src/tendencies/implicit/schur_complement_W.jl. These changes are needed in order to more easily extend the Atmos model, particularly to handle the new EDMFX model. Specifically, these changes will allow us to solve for the diagnostic EDMFX quantities, to implicitly solve for the prognostic EDMFX quantities, and to implicitly solve for the prognostic grid-scale quantities using the EDMFX quantities.