Refactor cubed sphere dss test #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/refactor_dss_test
branch
4 times, most recently
from
ff4aec2 to
81de114
Compare
charleskawczynski
force-pushed
the
ck/refactor_dss_test
branch
from
81de114 to
cea4137
Compare
charleskawczynski
force-pushed
the
ck/refactor_dss_test
branch
from
cea4137 to
9066a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the cubed sphere test by adding some utility functions that can be used for the cpu and gpu. I've also split out (what I hope to be) the unit test and cpu-gpu comparison test. Since it right now only does a cpu-gpu comparison, it runs the risk of both being wrong and matching. Ideally, we test the result against a simply computed result in the test suite, and that test can run both on the cpu and gpu.
The refactored test also tests covariant and contravariant transformations, which are not exercised in
ddss1.jl, so this PR also adds this as a CPU test to buildkite and the unit test suite.This is a step towards #1780.