Add fieldvector unit tests, update rcompare
#2072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fieldvector unit test, which was extracted from #2070, where the unit tests passed but a test in ClimaLand broke.
It's still not clear to me whether this is exercising broadcasting over different fieldvectors types with the same propertynames, or something different. Either way, we should probably test for that, plus, we could update
rcompare
to handle fieldvectors with different propertyname orders.