Fix bug in DSS of level Fields #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
reviewed
Feb 19, 2025
dennisYatunin
force-pushed
the
dy/level_dss_bugfix
branch
from
2a8ee81 to
fe30583
Compare
Test for correctness of DSS with level Fields has been added |
Sbozzolo
approved these changes
Feb 19, 2025
charleskawczynski
approved these changes
Feb 19, 2025
dennisYatunin
force-pushed
the
dy/level_dss_bugfix
branch
from
fe30583 to
d0649d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2193, which was accidentally introduced in #2136 while I was experimenting with extruded DSS weights. DSS should now work correctly for all types of Fields.