Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define divergence_result_type for missing case #2210

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Define divergence_result_type for missing case #2210

merged 1 commit into from
Mar 9, 2025

Conversation

charleskawczynski
Copy link
Member

Attempt to close #2208

@charleskawczynski charleskawczynski mentioned this pull request Mar 5, 2025
Closed
dennisYatunin
dennisYatunin requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@dennisYatunin dennisYatunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify this by extending previous code instead of defining new methods.

@charleskawczynski charleskawczynski marked this pull request as ready for review March 7, 2025 16:26
@charleskawczynski charleskawczynski merged commit 32225d3 into main Mar 9, 2025
35 checks passed
@charleskawczynski charleskawczynski deleted the ck/2208 branch March 9, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisYatunin dennisYatunin dennisYatunin approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in divergence_result_type
2 participants
@charleskawczynski @dennisYatunin