Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm weighted_dss_slab #959

Merged
merged 3 commits into from
Oct 14, 2024
Merged

rm weighted_dss_slab #959

merged 3 commits into from
Oct 14, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Sep 20, 2024

Purpose

We have been using a function weighted_dss_slab! that loops over each Field in the state FieldVector, retrieves the dss buffer from the cache, and then calls CC.Spaces.weighted_dss!(field, buffer). We can delete this function if we extend weighted_dss! to be extended for FieldVectors in ClimaCore, which will be useful for ClimaAtmos as well.

closes #396

To-do

@juliasloan25 juliasloan25 merged commit 25d5851 into main Oct 14, 2024
6 checks passed
@juliasloan25 juliasloan25 deleted the js/dss-t branch October 14, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dss operations within coupler pass an unused t argument.
2 participants