Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We have been using a function
weighted_dss_slab!
that loops over each Field in the state FieldVector, retrieves the dss buffer from the cache, and then callsCC.Spaces.weighted_dss!(field, buffer)
. We can delete this function if we extendweighted_dss!
to be extended for FieldVectors in ClimaCore, which will be useful for ClimaAtmos as well.closes #396
To-do