fix: decode nested prefixes in variant #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While #1501 added support for Variant/Dynamic/JSON arrays, this PR adds support for nested arrays of those types. For example,
Array(JSON)::Dynamic.The issue was that the underlying
Variantimplementation wasn't reading the prefixes of the inner columns. This was only an issue for column types that required a prefix themself, such asArray(JSON)insideDynamicorVariant. Some tests have been added to verify that there's no errors while decoding these.closes grafana/clickhouse-datasource#1168
Checklist