Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic on empty insert #139

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Don't panic on empty insert #139

merged 2 commits into from
Sep 4, 2024

Conversation

serprex
Copy link
Member

@serprex serprex commented Sep 3, 2024

Fixes #137

@serprex serprex requested review from loyd and slvrtrn September 3, 2024 18:19
@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@serprex serprex requested a review from heavycrystal September 4, 2024 14:45
slvrtrn
slvrtrn reviewed Sep 4, 2024
View reviewed changes
@serprex serprex merged commit a38d0ff into main Sep 4, 2024
5 of 6 checks passed
@loyd loyd deleted the fix-empty-insert branch September 11, 2024 07:44
@slvrtrn slvrtrn mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slvrtrn slvrtrn slvrtrn approved these changes

@loyd loyd Awaiting requested review from loyd

@heavycrystal heavycrystal Awaiting requested review from heavycrystal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

after few hundred inserts to db, the library panics
3 participants
@serprex @CLAassistant @slvrtrn