Skip to content

Commit

Permalink
fix: Remove entity code creation (#35)
Browse files Browse the repository at this point in the history
  • Loading branch information
ywei390 authored Nov 8, 2024
1 parent 68f87f0 commit 04a7602
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 17 deletions.
3 changes: 2 additions & 1 deletion docs/4.0.1-release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
- Set Accepted Entity Type to mandatory

# Fix
- Ficed Accept not responding correctly to configured entity type
- Fixed Accept not responding correctly to configured entity type
- No longer adding codes to entity
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,7 @@ public IEnumerable<Clue> BuildClues(ExecutionContext context, IExternalSearchQue
{
var resultItem = result.As<VatLayerResponse>();
var dirtyClue = request.CustomQueryInput.ToString();
var code = GetOriginEntityCode(resultItem, request);
var clue = new Clue(code, context.Organization);
var clue = new Clue(request.EntityMetaData.OriginEntityCode, context.Organization);

PopulateMetadata(clue.Data.EntityData, resultItem, request);

Expand Down Expand Up @@ -384,24 +383,11 @@ private IEntityMetadata CreateMetadata(IExternalSearchQueryResult<VatLayerRespon
return metadata;
}

private EntityCode GetOriginEntityCode(IExternalSearchQueryResult<VatLayerResponse> resultItem, IExternalSearchRequest request)
{
return new EntityCode(request.EntityMetaData.EntityType, this.GetCodeOrigin(), request.EntityMetaData.OriginEntityCode.Value);
}

private CodeOrigin GetCodeOrigin()
{
return CodeOrigin.CluedIn.CreateSpecific("vatlayer");
}

private void PopulateMetadata(IEntityMetadata metadata, IExternalSearchQueryResult<VatLayerResponse> resultItem, IExternalSearchRequest request)
{
var code = GetOriginEntityCode(resultItem, request);

metadata.EntityType = request.EntityMetaData.EntityType;
metadata.Name = request.EntityMetaData.Name;
metadata.OriginEntityCode = code;
metadata.Codes.Add(request.EntityMetaData.OriginEntityCode);
metadata.OriginEntityCode = request.EntityMetaData.OriginEntityCode;

metadata.Properties[VatLayerVocabulary.Organization.Name] = resultItem.Data.CompanyName;

Expand Down

0 comments on commit 04a7602

Please sign in to comment.