Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend for sources update #204

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Frontend for sources update #204

merged 4 commits into from
Sep 6, 2024

Conversation

danzjamz
Copy link
Collaborator

@danzjamz danzjamz commented Sep 6, 2024 •
edited
Loading

The Pull Request is ready

Intention

With this change I intend to...
Add frontend functionality to the sources component

The code follows best practices

  • duplicate code has been extracted where possible
  • issues for follow-up tasks have been created
  • tests have been written for any new functionality
  • there is no any type used
  • texts have been checked for grammar and spelling issues

Notes

Updated the query to return only user's used sources;
Updated frontend to use new query data for sources

@danzjamz danzjamz requested a review from rphovley September 6, 2024 19:45
rphovley
rphovley previously approved these changes Sep 6, 2024
View reviewed changes
@danzjamz danzjamz merged commit bf227b7 into main Sep 6, 2024
8 checks passed
@danzjamz danzjamz deleted the issue-196-sources-update branch September 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphovley rphovley rphovley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "Sources" Widget to include times for sources and sites
2 participants
@danzjamz @rphovley