Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 0 fix vite warnings #213

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Issue 0 fix vite warnings #213

merged 1 commit into from
Sep 13, 2024

Conversation

rphovley
Copy link
Member

The Pull Request is ready

  • all github actions are passing
  • only a single issue was worked on
  • fixes #0
  • the branch follows the naming schema issue-123-enable-x-does-not-disable-y
  • the pull request has a sensible title

Intention

With this change I intend to...

Review Points

Please take extra care reviewing...

The code follows best practices

  • duplicate code has been extracted where possible
  • issues for follow-up tasks have been created
  • tests have been written for any new functionality
  • there is no any type used
  • texts have been checked for grammar and spelling issues

Notes

@rphovley rphovley merged commit 1663bc3 into main Sep 13, 2024
7 of 9 checks passed
@rphovley rphovley deleted the issue-0-fix-resolvers branch September 13, 2024 22:43
@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 9682a80):

https://codeclimbersio--pr213-issue-0-fix-resolver-8fafekfd.web.app

(expires Fri, 20 Sep 2024 22:44:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3c28ab1d661a7526dc2530b2448a1aa4f88d23d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rphovley