Issue 212 frontend query sql #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 00ad14a): https://codeclimbersio--pr221-issue-212-frontend-q-3pfssudm.web.app (expires Sat, 28 Sep 2024 00:19:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 3c28ab1d661a7526dc2530b2448a1aa4f88d23d4 |
rphovley
force-pushed
the
issue-212-frontend-query-sql
branch
from
0bdbe9f to
24444e5
Compare
| target?: string | ||
| } | ||
|
|
||
| const CodeClimbersLoadingButton = ({ |
There was a problem hiding this comment.
Wouldn't it just be better to have a generic button component that takes in the eventName? LoadingButton to me mean that you'd be displaying a spinner and expect a isLoading | isPending prop
|
|
||
| function DashboardLayout({ children }: DashboardLayoutProps) { | ||
| const { isMajorUpdate, isMinorUpdate } = useUpdateVersionHook() | ||
| if (isMajorUpdate || isMinorUpdate) { |
| @@ -28,7 +29,20 @@ export async function bootstrap() { | |||
| }) | |||
| traceEnvironment() | |||
|
|
|||
| app.enableCors() | |||
| app.enableCors({ | |||
| credentials: 'include', | ||
| }) | ||
| return useBetterQuery<T[], Error>({ | ||
| queryKey: ['localdb/query'], |
There was a problem hiding this comment.
You'll want to make this key unique per query string passed in. As is it'll reuse the same key for any query string passed in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request is ready
issue-123-enable-x-does-not-disable-yChanges
The code follows best practices
anytype usedNotes