Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/fix missing package #234

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Hotfix/fix missing package #234

merged 3 commits into from
Oct 1, 2024

Conversation

rphovley
Copy link
Member

@rphovley rphovley commented Oct 1, 2024

Revert back changes to bring extensions code with the fix. Needed some missing packages. Also added a way for ci to check for whether or not the installed package will be able to run the commands like npx codeclibmers start

The Pull Request is ready

  • all github actions are passing

  • are changes backwards compatible?

  • fixes #0

  • the branch follows the naming schema issue-123-enable-x-does-not-disable-y

  • the pull request has a sensible title

  • the code is readable

  • issues for follow-up tasks have been created

  • there is no any type used

Notes

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Visit the preview URL for this PR (updated for commit fb2c676):

https://codeclimbersio--pr234-hotfix-fix-missing-p-yksed6q1.web.app

(expires Tue, 08 Oct 2024 03:49:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3c28ab1d661a7526dc2530b2448a1aa4f88d23d4

@rphovley rphovley merged commit 42f1394 into main Oct 1, 2024
9 of 10 checks passed
@rphovley rphovley deleted the hotfix/fix_missing_package branch October 1, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant