Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 0/contributors #242

Merged
merged 3 commits into from
Oct 6, 2024
Merged

Issue 0/contributors #242

merged 3 commits into from
Oct 6, 2024

Conversation

rphovley
Copy link
Member

@rphovley rphovley commented Oct 6, 2024

The Pull Request is ready

  • all github actions are passing
  • are changes backwards compatible?
  • fixes #0
  • the branch follows the naming schema issue-123-enable-x-does-not-disable-y
  • the pull request has a sensible title

Intention

With this change I intend to add contributors to the extensions widget

The code follows best practices

  • the code is readable
  • issues for follow-up tasks have been created
  • there is no any type used

Notes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Visit the preview URL for this PR (updated for commit ce3a935):

https://codeclimbersio--pr242-issue-0-contributors-24cu8w7y.web.app

(expires Sun, 13 Oct 2024 19:01:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3c28ab1d661a7526dc2530b2448a1aa4f88d23d4

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 6, 2024
View reviewed changes
packages/app/src/components/common/SimpleInfoCard.tsx
callout,
href,
}: SimpleInfoCardProps) => {
const isGithubUrl = subjectUrl?.includes('github.com')

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
github.com
Loading
' can be anywhere in the URL, and arbitrary hosts may come before or after it.

Copilot Autofix AI 5 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@rphovley rphovley merged commit 8712c90 into main Oct 6, 2024
9 of 11 checks passed
@rphovley rphovley deleted the issue-0/contributors branch October 6, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rphovley