Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Google Analytics #1035

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Unify Google Analytics #1035

merged 10 commits into from
Feb 4, 2025

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Jan 24, 2025 •
edited
Loading

Description

This PR unifies how we're handling Google Analytics in all apps

  1. For applications that have cms, the Google Analytics ID will be set in the CMS under the Engagement tab.
  2. For those that do not, we will use an env variable NEXT_PUBLIC_GOOGLE_ANALYTICS_ID

Fixes #1034

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto
Unify Google Analytics
9bd03a6 
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Fix Pesayetu env variable
457e106 
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Update Charter Africa env variable
b09a08d
@kelvinkipruto kelvinkipruto marked this pull request as ready for review January 24, 2025 11:34
kilemensi
kilemensi reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

  1. In docker, if we don't include GA id at build time, can we change it at run time e.g. Dokku config?
  2. Do we need to update app scripts/config in vault?

apps/charterafrica/.env Outdated Show resolved Hide resolved
@koechkevin
Copy link
Contributor

@kelvinkipruto I found this error trying to run charterafrica
image

@koechkevin
Copy link
Contributor

@kelvinkipruto I found this error trying to run charterafrica image

Ignore this, I hadn't rerun pnpm i

@kelvinkipruto kelvinkipruto force-pushed the chore/unify-google-analytics branch from 66f4b82 to b09a08d Compare January 28, 2025 12:17
@kelvinkipruto
use NEXT_PUBLIC_GOOGLE_ANALYTICS
42f09a7 
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Merge branch 'main' into chore/unify-google-analytics
c6d7b2c
@kelvinkipruto
Add google analytics promise tracker
15a99a2 
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto kelvinkipruto self-assigned this Jan 29, 2025
kilemensi
kilemensi approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 ... haven't run it locally but code looks solid.

@kelvinkipruto kelvinkipruto added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit fe670c1 Feb 4, 2025
5 of 6 checks passed
@kelvinkipruto kelvinkipruto deleted the chore/unify-google-analytics branch February 4, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@koechkevin koechkevin koechkevin approved these changes

Assignees

@kelvinkipruto kelvinkipruto

Labels
None yet
Projects
COMMONS
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct PesaYetu and ClimateMapped Google Analytics ID
3 participants
@kelvinkipruto @koechkevin @kilemensi