Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update email, link support to slack #9

Closed
wants to merge 1 commit into from

Conversation

VinneyJ
Copy link

@VinneyJ VinneyJ commented May 22, 2024

  1. Replaced the Join "our mailing list" URL with the Slack form URL.
  2. Updated the "Support" URL to the Slack form URL.
  3. Updated the FAQ email to the CivicSignal email.

@kilemensi
Copy link
Member

Why is there like 89 file changes @VinneyJ / @thepsalmist ?

@VinneyJ
Copy link
Author

VinneyJ commented May 22, 2024

Why is there like 89 file changes @VinneyJ / @thepsalmist ?

I had to update the Slack form URL in all the files within the "server/static/gen/" path since the changes in files 1, 2, and 3 didn't work. Additionally, the folder containing these files or folder wasn't listed in the .gitignore file, so I figured they were necessary. I made the changes and pushed them; all the files with the support link needed to be updated to the Slack form URL. As for the FAQ, I only had to change about two files. Or perhaps @thepsalmist , could you explain the purpose of app_js.{random-uuid}.js files in that particular path?

@kilemensi
Copy link
Member

I had to update the Slack form URL in all the files within the "server/static/gen/" ...

Lets discuss this tomorrow @VinneyJ but looking at the folder name static/gen and the way files in that folder are randomly named, I have to assume they're auto generated by the build tool from actual source files.

@thepsalmist
Copy link

Why is there like 89 file changes @VinneyJ / @thepsalmist ?

I had to update the Slack form URL in all the files within the "server/static/gen/" path since the changes in files 1, 2, and 3 didn't work. Additionally, the folder containing these files or folder wasn't listed in the .gitignore file, so I figured they were necessary. I made the changes and pushed them; all the files with the support link needed to be updated to the Slack form URL. As for the FAQ, I only had to change about two files. Or perhaps @thepsalmist , could you explain the purpose of app_js.{random-uuid}.js files in that particular path?

The files in server/static are generated on build with npm run <app-name>, we require this on deployment (based on the current Git deployment)

@VinneyJ VinneyJ closed this May 23, 2024
@VinneyJ VinneyJ deleted the email-support/update branch May 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants