-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with python3.13 #25
Fix compatibility with python3.13 #25
Conversation
7c9a992
to
85b8563
Compare
@sam-leonard-ct updating bottle is breaking a few |
I'm not seeing any mypy changes on my side? could you point me towards what is broken? |
https://github.com/CodethinkLabs/doorstop/actions/runs/12599127892/job/35115386661 <- your PR Have you tried to run make check locally? https://github.com/CodethinkLabs/doorstop/actions/runs/12747712823/job/35526541040 <- CI without bottles updated |
Yes I get those errors on main as well.
These errors actually come from upgrading mypy to 0.14.1 as the version of mypy in pyproject.toml is "^1.1.1" so it got updated when stuff changed. I'll see if I can address these mypy complaints easily and if not I'll pin mypy's version to what it is in main's poetry.lock file. |
db7be77
to
11ec867
Compare
So the mypy errors are fixed, I'm not super sure about what the correct behaviour should be for the HTML one considering its just going to cause an error if its None anyway in the last case at least? |
Upgrades dep bottle from ~0.12.25 to ~0.13.2, all versions 0.13 and up contain the fix to bottle allowing it to work with python 3.13.
11ec867
to
e0cf77c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Upgrades dep bottle from ~0.12.25 to ~0.13.2, all versions 0.13 and up contain the fix to bottle allowing it to work with python 3.13.