feat(helm): Add extraVolumes and extraVolumeMounts options #10977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Things that will help get your PR across the finish line:
|
Rash419
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looks good. But can you please sign the commit so DCO check can pass https://github.com/CollaboraOnline/online/pull/10977/checks?check_run_id=35939682621
dominikkaminski
force-pushed
the
feat/helm-add-extra-volumes
branch
from
5823080 to
f2cd5ea
Compare
|
@dominikkaminski there is still a change id check failure: https://cpci.cbg.collabora.co.uk:8080/job/github_change-id_check/16650/ |
Signed-off-by: Dominik Kaminski <dominik.kaminski.extern@zendis.de> Change-Id: I860e58d2b684fc03c4f1756eb36f7b2a5a56da8b
timar
force-pushed
the
feat/helm-add-extra-volumes
branch
from
f2cd5ea to
3727af0
Compare
|
Thanks a lot for your contribution, and congrats on your first pull request merged! Welcome aboard! 🎉🎉🎉 If you haven't decided on your next task yet, take a look at our easy-hacks. We're looking forward to your next pull request! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay