-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Architecture Decisions Records #13019
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my first round of feedback to the discussion started.
For a better collaboration and documentation. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
The "-" in file name was also replaced by "_" to better align with other documentation files. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall the description looks good to me and looking forward to more on this topic
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Code Climate has analyzed commit d4d093b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcusburghardt for working through my comments.
LGTM.
Description:
This PR introduces an Architecture Decisions Records in the project.
The intention is to make it easier to track architectural decisions along the time and to ensure more assertive decisions by introducing a simple and effective process.
This does not affect the communication we already have in Issues, PRs, Discussions, Gitter, Meetings or wherever.
But brings more transparency and reasoning regarding architecture decisions in the project.
Rationale:
For a better collaboration, documentation and transparency.
Review Hints:
Please, also take a look in the reference documents in
0000_architecture_decisions_records
for a better context of this proposal.