fix golang critics in commands

pkg/snclient/commands/daemon.go

@@ -14,7 +14,7 @@ func init() {
 All logs will be written to the configured logfile.
 `,
 		GroupID: "daemon",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			agentFlags.Mode = snclient.ModeServer
 			snc := snclient.NewAgent(agentFlags)
 			snc.CheckUpdateBinary("daemon")

pkg/snclient/commands/dev.go

@@ -1,6 +1,9 @@
 package commands
 
 import (
+	"fmt"
+	"os"
+
 	"pkg/snclient"
 
 	"github.com/spf13/cobra"
@@ -10,9 +13,12 @@ func init() {
 	devCmd := &cobra.Command{
 		Use:   "dev",
 		Short: "Collection of development commands",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			rootCmd.SetArgs([]string{"help", "dev"})
-			rootCmd.Execute()
+			if err := rootCmd.Execute(); err != nil {
+				fmt.Fprintf(os.Stderr, "command failed: %s", err.Error())
+				os.Exit(3)
+			}
 		},
 		Hidden: true,
 	}
@@ -25,7 +31,7 @@ func init() {
 		Long: `start the agent and watch for file changes in the config files or the agent itself.
 The agent will be restarted immediately on file changes.
 `,
-		Run: func(cmd *cobra.Command, _ []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			agentFlags.Mode = snclient.ModeServer
 			snc := snclient.NewAgent(agentFlags)
 			snc.StartRestartWatcher()

pkg/snclient/commands/hash.go

@@ -29,7 +29,7 @@ snclient hash
 		Run: func(cmd *cobra.Command, args []string) {
 			agentFlags.Mode = snclient.ModeOneShot
 			setInteractiveStdoutLogger()
-			input := ""
+			var input string
 			if len(args) > 0 {
 				input = args[0]
 			} else {
@@ -55,7 +55,7 @@ snclient hash
 
 func readPassword(cmd *cobra.Command) string {
 	fmt.Fprintf(cmd.OutOrStdout(), "enter password to hash or hit ctrl+c to exit.\n")
-	b, _ := term.ReadPassword(int(syscall.Stdin))
+	b, _ := term.ReadPassword(int(syscall.Stdin)) //nolint:unconvert,nolintlint // unconvert detects a conversion here but it is one on windows
 
 	return string(b)
 }