[CBW-1218] Block WalletConnect multiple requests at the same time #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prinshamlet
changed the title
prinshamlet
changed the title
prinshamlet
changed the title
prinshamlet
changed the title
prinshamlet
changed the title
prinshamlet
changed the title
bisgardo
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For safety, it is important to not allow dApps to send requests upon other request. It can mislead a user and make him accept request, that he/she would've otherwise not approved.
Changes
In order to prevent that, a bool flag has been added and is set
truewhen a request is pending. After it's rejected or accepted, the flag is set back to false.Jira ticket: https://concordium.atlassian.net/browse/CBW-1218