ref: Config schema #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why, but this branch requires that the aws global region be specified. That's why CI tests are failing. I don't see any obvious reason for the change in behavior. In the old code, we pass in an empty region to the AWS client initialization and it works fine. |
mgaeta
force-pushed
the
marcos/ref/config-schema
branch
2 times, most recently
from
6970587 to
08ad3fb
Compare
mgaeta
force-pushed
the
marcos/ref/config-schema
branch
from
08ad3fb to
cf8a971
Compare
mgaeta
force-pushed
the
marcos/ref/config-schema
branch
from
cf8a971 to
a58b4bb
Compare
* add new annotation * move resource types to a file * Moke identity store client an interface * add unit tests * fix tests
ggreer
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go.modto latestTODO