Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unwraps in the function when parsing a trace #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove unwraps in the function when parsing a trace #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/column.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,12 +663,12 @@
if wrap {
let new_i = v.len() as isize + i;
if new_i < 0 {
Some(v.get(0).unwrap())
v.get(0)
} else {
v.get(new_i as usize)
}
} else if i < -spilling {
Some(v.get(0).unwrap())
v.get(0)
} else {
v.get((i + spilling) as usize)
}
Expand Down Expand Up @@ -910,7 +910,7 @@
pub handle: Handle,
computed: bool,
}
#[buildstructor::buildstructor]

Check warning on line 913 in src/column.rs

View workflow job for this annotation

GitHub Actions / build 

unexpected `cfg` condition value: `cargo-clippy`
impl Column {
#[builder]
pub fn new(
Expand Down Expand Up @@ -1175,7 +1175,7 @@
pub fn iter_module<'a>(
&'a self,
module: &'a str,
) -> impl Iterator<Item = (ColumnRef, &Column)> + 'a {

Check warning on line 1178 in src/column.rs

View workflow job for this annotation

GitHub Actions / build 

elided lifetime has a name
self.iter().filter(move |c| c.1.handle.module == module)
}

Expand Down
Loading