Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ContractAddrLen variable #2111

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Make ContractAddrLen variable #2111

merged 3 commits into from
Jan 31, 2025

Conversation

chipshort
Copy link
Collaborator

This should allow chains to customize the address length for contract addresses (both classic and instantiate2).
It's related to this issue: CosmWasm/cosmwasm#2155 (comment)
Injective implemented this for their fork (they use 20).

@chipshort chipshort requested a review from pinosu January 31, 2025 16:17
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.22%. Comparing base (4c5feae) to head (b856840).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
+ Coverage   46.20%   46.22%   +0.01%     
==========================================
  Files          78       78              
  Lines       10810    10810              
==========================================
+ Hits         4995     4997       +2     
+ Misses       5368     5367       -1     
+ Partials      447      446       -1     
Files with missing lines Coverage Δ
x/wasm/types/types.go 60.25% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chipshort chipshort merged commit 6c087f9 into main Jan 31, 2025
19 checks passed
@chipshort chipshort deleted the co/allow-custom-address-len branch January 31, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants