Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure scope includes all elements with the same name #104

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Ensure scope includes all elements with the same name #104

merged 1 commit into from
Feb 28, 2025
+22 −1

Conversation

martin-fleck-at
Copy link
Collaborator

Fixes #98

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

Unit Test Results

  3 files  + 1   27 suites  +9   2m 19s ⏱️ +44s
 42 tests ± 0   42 ✅ ± 0  0 💤 ±0  0 ❌ ±0 
126 runs  +42  126 ✅ +42  0 💤 ±0  0 ❌ ±0 

Results for commit 93535d4. ± Comparison against base commit 2d51d55.

♻️ This comment has been updated with latest results.

@harmen-xb
Copy link
Contributor

@martin-fleck-at Is this ready for review?

@martin-fleck-at
Copy link
Collaborator Author

@harmen-xb Yes, it is!

harmen-xb
harmen-xb approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and seem to fix the issue.

@harmen-xb harmen-xb merged commit af6be1e into main Feb 28, 2025
7 of 9 checks passed
@harmen-xb harmen-xb deleted the feature/98 branch February 28, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harmen-xb harmen-xb harmen-xb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot have 2 entities with same ID in different systems after restart
2 participants
@martin-fleck-at @harmen-xb