Enhancements made according to ISC #42
Conversation
There was a problem hiding this comment.
This feature is called Alarm Mapping e.g. see it's documentation: https://cumulocity.com/docs/standard-tenant/alarm-mapping/ Why should we name it differently here?
There was a problem hiding this comment.
Alarm Mapping doesn’t accurately describe its function. We are modifying the alarm, so Alarm Transformation is more appropriate. The customer specifically requested that the label not convey its true purpose.
There was a problem hiding this comment.
Then you would need to keep your changes in a fork. We are not going to rename Cumulocity features here.
| />`, | ||
| }) | ||
| export class ProvisionIconComponent { | ||
| imageSource = require("/assets/icf_asset-management.svg"); |
There was a problem hiding this comment.
This icon seems to be missing?
| this.tenantService.current().then((tenant) => { | ||
| this.tenant = tenant.data; | ||
| }); | ||
| } |
There was a problem hiding this comment.
If you nee the current tenant, please use the AppStateService instead of performing an additional request..
| .firmeware-list .selected, .tenant-list .selected{ | ||
| background-color: #f5f5f5; | ||
| } |
There was a problem hiding this comment.
Please pick a color form the c8y branding variables, instead of defining your own
There was a problem hiding this comment.
If you want to add JSDoc comments, you do not need to repeat the name of the method within your comment.
|
Please also consider to split this PR into multiple ones (e.g. one per feature) to make the review a bit simpler. |
Here is a summary of the enhancements :
o The "Alarm Mapping" tab has been renamed to "Alarm Transformation".
o Added the ability to provision bulk devices on a selected tenant using bulk upload features.
o List all default EPL rules in the current tenant.
o Deploy these rules across all selected tenants if the multi-tenant Apama microservice is not used.
o List all default analytics builder models in the current tenant.
o Deploy these models across all selected tenants if the multi-tenant Apama microservice is not used.
o Before provisioning firmware, now it checks if the firmware with the same version already exists; if it does, it will ignore it; otherwise, it will provision the selected firmware.
o Added tenant ID at the header level for context identification of global roles.
o Added centralized management (Create/Update/Delete) of global roles by redirecting to the standard Cumulocity implementation i.e, Administration -> Global roles.
o Included a list of applications where these global roles are applied.
o Display associated permissions within each role.
o Renamed the header from "Role" to "Permissions" for better representation.
o Added tenant ID at the header level to identify the context of tenant options.
o Fixed the issue where firmware statistics did not display the correct value. Diagram to check which firmware version is installed on which amount of devices for a specific sub-tenant