Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cluster parameters #128

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Fix/cluster parameters #128

merged 3 commits into from
Jan 20, 2025

Conversation

gh271
Copy link

@gh271 gh271 commented Jan 17, 2025

Changes

  • Removed not existing mariadb_toolkit_enabled and mariadb_toolkit_scans_enabled parameters
  • Fixed parameter names for cluster parameters added in Core API 1.224
    • single_store -> singlestore
    • rabbit_mq -> rabbitmq
  • Added cluster parameters added in Core API to create/update request's validateRequired and filterFields

Checks

  • The version constant is updated in Client.php
  • The changelog is updated (when applicable)

@gh271 gh271 force-pushed the fix/cluster-parameters branch from 535597d to 95d6fb8 Compare January 17, 2025 13:38
@gh271 gh271 force-pushed the fix/cluster-parameters branch from 95d6fb8 to 36fbc1d Compare January 17, 2025 13:39
@WilliamDEdwards
Copy link
Contributor

Reviewed. LGTM.

@dvdheiden Please check as well.

@dvdheiden dvdheiden merged commit 0b5aa61 into CyberfusionIO:main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdheiden dvdheiden Awaiting requested review from dvdheiden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gh271 @WilliamDEdwards @dvdheiden