Skip to content

Commit

Permalink
chore(deps): no longer depend on dependency packageurl-js (#1237)
Browse files Browse the repository at this point in the history
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
  • Loading branch information
jkowalleck authored Nov 20, 2024
1 parent 2593612 commit cb429b5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 3 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@ All notable changes to this project will be documented in this file.

<!-- unreleased changes go here -->

* Dependencies
* No longer depend on `packageurlk-js` (via [#1237])
* Build
* Use _TypeScript_ `v5.6.2` now, was `v5.5.3` (via [#1209], [#1218])

[#1209]: https://github.com/CycloneDX/cyclonedx-node-npm/pull/1209
[#1218]: https://github.com/CycloneDX/cyclonedx-node-npm/pull/1218
[#1237]: https://github.com/CycloneDX/cyclonedx-node-npm/pull/1237

## 1.19.3 -- 2024-07-15

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"@cyclonedx/cyclonedx-library": "^6.11.0",
"commander": "^10.0.0",
"normalize-package-data": "^3||^4||^5||^6",
"packageurl-js": "^1.2.1",
"xmlbuilder2": "^3.0.2"
},
"devDependencies": {
Expand Down
3 changes: 1 addition & 2 deletions src/builders.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Copyright (c) OWASP Foundation. All Rights Reserved.
import { type Builders, Enums, type Factories, Models, Utils } from '@cyclonedx/cyclonedx-library'
import { existsSync } from 'fs'
import * as normalizePackageData from 'normalize-package-data'
import { type PackageURL } from 'packageurl-js'
import * as path from 'path'

import { isString, loadJsonFile, tryRemoveSecretsFromUrl } from './_helpers'
Expand Down Expand Up @@ -544,7 +543,7 @@ export class BomBuilder {
return component
}

private makePurl (component: Models.Component): PackageURL | undefined {
private makePurl (component: Models.Component): ReturnType<BomBuilder['purlFactory']['makeFromComponent']> {
const purl = this.purlFactory.makeFromComponent(component, this.reproducible)
if (purl === undefined) {
return undefined
Expand Down

0 comments on commit cb429b5

Please sign in to comment.