Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tools as components #1235

Merged
merged 15 commits into from
Jan 23, 2025
Merged

feat: tools as components #1235

merged 15 commits into from
Jan 23, 2025

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Nov 19, 2024

fixes #1233

TODO

  • bump deps
  • implement new things
  • bump tests
  • write history

@jkowalleck jkowalleck added enhancement New feature or request breaking-change breacking change. causes a new major version. labels Nov 19, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner November 19, 2024 14:52
@jkowalleck jkowalleck marked this pull request as draft November 19, 2024 14:52
Copy link

codacy-production bot commented Nov 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.08% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (33c1136) 1338 1086 81.17%
Head commit (3748755) 1332 (-6) 1080 (-6) 81.08% (-0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1235) 9 9 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member Author

@jkowalleck jkowalleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML files missing after test data generation ...

@jkowalleck jkowalleck changed the title [WIP] tools as components feat: tools as components Nov 26, 2024
@jkowalleck jkowalleck marked this pull request as ready for review November 26, 2024 13:53
@jkowalleck jkowalleck added this to the v2.0.0 milestone Dec 19, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the feat/tools-as-components branch from f75110c to ae00832 Compare January 23, 2025 07:55
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit edb3165 into main Jan 23, 2025
34 checks passed
@jkowalleck jkowalleck deleted the feat/tools-as-components branch January 23, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change breacking change. causes a new major version. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] emit tools as metadata.tools.components
1 participant