Fix MEI encoding job #1257

yinanazhou · 2025-02-28T16:13:37Z

I passed the docker hub test, and images can be built successfully.
I passed the GitHub CI test, so rodan functionalities and jobs work.

Changes:

update to MEI v5.1
group all-zero dummy syl to first syllable
add liquescent element inside nc
generate zone for syl only when syllable gets inserted

- Pass `layer` and `surface` to `SylMachine` - Only generate `zone` and insert to `surface` when the `syllable` is inserted into `layer` to avoid ghost `zones` refs: #1117

homework36

tested locally

yinanazhou added 5 commits February 7, 2025 11:03

fix: update to MEI v5.1

d0de3b6

refs: #1122

fix: group all-zero dummy syl to first syllable

d8c130d

refs: #643, #1116

fix: add liquescent element inside nc

12cdcfa

refs: #1123

fix: generate zone for syl only when syllable gets inserted

dbe17f7

- Pass `layer` and `surface` to `SylMachine` - Only generate `zone` and insert to `surface` when the `syllable` is inserted into `layer` to avoid ghost `zones` refs: #1117

test: update MEI encoding test result

786853b

yinanazhou force-pushed the fix-mei branch from aa3e576 to 786853b Compare February 28, 2025 16:42

yinanazhou requested a review from homework36 February 28, 2025 16:49

homework36 approved these changes Feb 28, 2025

View reviewed changes

yinanazhou merged commit 8344a78 into develop Mar 1, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix MEI encoding job #1257

Fix MEI encoding job #1257

yinanazhou commented Feb 28, 2025 •

edited

Loading

homework36 left a comment

Fix MEI encoding job #1257

Fix MEI encoding job #1257

Conversation

yinanazhou commented Feb 28, 2025 • edited Loading

homework36 left a comment

Choose a reason for hiding this comment

yinanazhou commented Feb 28, 2025 •

edited

Loading