Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for logo's max size in communities and collections #2744

Closed
wants to merge 2 commits into from

Conversation

FrancescoMolinaro
Copy link
Contributor

@FrancescoMolinaro FrancescoMolinaro commented Jan 17, 2024

References

Fixes #2745

Description

To prevent logos to be over sized we added a configuration possibility so that on each environment we can restrict the size to a number of defined pixels.

Instructions for Reviewers

In order to test try creating a new collection or community uploading a very large picture as logo to check if it is rendered within the defined configuration sizes.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge component: Community Community display or editing component: Collection Collection display or editing labels Jan 17, 2024
@alexandrevryghem
Copy link
Member

Hey @FrancescoMolinaro thnx for this new functionality, but I think we should keep using css variables in order to configure style changes like done here. Doing it this way would also simplify this functionality, because it would only require you to add 2 new css variables to src/styles/_custom_variables.scss (e.g.--ds-comcol-logo-max-width & --ds-comcol-logo-max-height). Afterwards you simply need to apply these variables in the src/app/shared/comcol/comcol-page-logo/comcol-page-logo.component.scss stylesheet. (It will probably be easier to start over again so you might want to close this PR & create a new one if it's easier for you)

@FrancescoMolinaro
Copy link
Contributor Author

FrancescoMolinaro commented Jan 18, 2024

Hi @alexandrevryghem , thanks for the feedback, I am going to close this PR and open a new one according to your suggestion.

@FrancescoMolinaro FrancescoMolinaro deleted the DURACOM-223 branch January 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: Collection Collection display or editing component: Community Community display or editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community/Collection logo over sized if image is big
4 participants