Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-8_x] ORCID Push Queue: add support for Products and Patents #3356

Open
wants to merge 5 commits into
base: dspace-8_x
Choose a base branch
from

Conversation

atarix83
Copy link
Contributor

References

Description

This is the PR for DSpace 8 version of #3351

Instructions for Reviewers

See #3351

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@atarix83 atarix83 marked this pull request as ready for review September 26, 2024 07:17
@atarix83 atarix83 changed the title ORCID Push Queue: add support for Products and Patents ORCID Push Queue: add support for Products and Patents (dspace-8_x) Sep 26, 2024
@tdonohue tdonohue changed the title ORCID Push Queue: add support for Products and Patents (dspace-8_x) [Port dspace-8_x] ORCID Push Queue: add support for Products and Patents Sep 26, 2024
@tdonohue tdonohue added component: configurable entities related to configurable entities integration: ORCID Related to integration with ORCID identifier system labels Sep 26, 2024
Copy link

github-actions bot commented Dec 2, 2024

Hi @atarix83,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@tdonohue
Copy link
Member

From a brief discussion with the ORCID US Consortium, it's clear that these Product/Patent PRs are "nice to have" but not as high priority as the other ORCID integration bug fix PRs that were funded by the ORCID Global Participation Fund grant.

Therefore, I'm going to leave these Product/Patent PRs open, but I've flagged them all as "low priority" as they are waiting for more feedback from the DSpace community. Up until now, I haven't heard requests to add "Product" and "Patent" as new Entity Types in DSpace. So, we need to get more feedback on that idea -- if many agree these types should be added, then we will immediately move these PRs forward.

But, in the meantime, sites that want Product/Patent integration with ORCID should feel free to test these PRs and report back. That will help us to better determine the demand for this feature.

…ucts_orcid

# Conflicts:
#	src/app/item-page/orcid-page/orcid-sync-settings/orcid-sync-settings.component.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: configurable entities related to configurable entities integration: ORCID Related to integration with ORCID identifier system low priority
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

3 participants