[Port dspace-7_x] use translation service to determine placeholder values of date picker #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSpace#2827) * use translation service to determine placeholder values * added translation of date-picker placeholder values * added German translations of date-picker placeholder values * fix lint warning: added missing comma * fix lint warning: removed trailing spaces * fixed broken tests * fixed lint warning * try to mock TranslateService correctly * remove TranslateService mock * removed imports * fixed lint warnings * fixed lint warnings * fixed lint warning * fixed lint warning * fixed lint error * fixed lint errors * removed TestComponent * added imports * removed declarations * fixed lint error * fix lint error (invalid sorting) * finally fixing lint error * use translation pipe directly in template * move translation of placeholders into HTML template * remove TranslateService dependency
tdonohue
added
bug
i18n / l10n
tdonohue
commented
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual port of #2827 by @saschaszott to
dspace-7_x