Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enablePerformanceProfiler option to last in list in config.example.yml #3966

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Feb 6, 2025

Description

Tiny PR to cleanup config.example.yml (which is just an example configuration). This moves the enablePerformanceProfiler option for ssr to the last item in the list & comments it out by default. This option should never be used in production and is a debugging tool, so it makes no sense to list it first.

Instructions for Reviewers

  • This changes no code in DSpace. This config.example.yml is unused and is just meant for documentation.

@tdonohue tdonohue added configuration code task 1 APPROVAL pull request only requires a single approval to merge labels Feb 6, 2025
@tdonohue tdonohue added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Feb 7, 2025
Copy link
Member Author

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor change just to move this debug-only setting to the bottom of the list, instead of the top. Merging immediately to get this into 8.1

@tdonohue tdonohue merged commit f088233 into DSpace:main Feb 7, 2025
15 checks passed
@tdonohue tdonohue added this to the 9.0 milestone Feb 7, 2025
@dspace-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge code task configuration port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants