Migration to NX and refactor of Utils and Core into libraries. #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reState in tests files, move remote data utils into core
…r, move config (app) into core, move core states files into core folder, replace import of some constants for route paths with strings to avoid import/dependency from other part of the app
…r, move config (app) into core, move core states files into core folder, replace import of some constants for route paths with strings to avoid import/dependency from other part of the app
… of AppState + move notification state in core
…ndex.ts files, refactor import
tdonohue
added
dependencies
|
Hi @FrancescoMolinaro, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
https://wiki.lyrasis.org/display/DSPACE/DSpace+Angular+%3A+library-based+architecture+proposal
Work includes also #3997 as we started from there to avoid future conflicts.
Description
This PR is a follow up of the migration to standalone components done in DSpace 8, with the goal of a modular architecture.
The new code serves two main purposes, first it introduces NX in the project as build orchestrator, second it introduces two new libraries: Core and Utils.
Instructions for Reviewers
The app needs to be running as before and the commands to run it remain unchanged.
List of changes in this PR:
Migrated from an Angular CLI project to a NX standalone App.
The Angular CLI has been replaced by the NX CLI.
Created two new libraries Core and Utils:
2.a Moved all data services and related models into Core.
2.b Moved some of the states from AppState to CoreState to isolate the library.
2.c Replaced in the whole library the environment import with injection token.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.