Zad6 - partial #267
Open
Zad6 - partial #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahawrylak
reviewed
Dec 11, 2018
| @@ -0,0 +1,5 @@ | |||
| class Category < ApplicationRecord | |||
| has_many :products, through: :category_products | |||
There was a problem hiding this comment.
do wcięć używamy 2 spacji
| @@ -0,0 +1,5 @@ | |||
| class Category < ApplicationRecord | |||
| has_many :products, through: :category_products | |||
There was a problem hiding this comment.
brakuje has_many :category_products
| @@ -0,0 +1,6 @@ | |||
| class Customer < ApplicationRecord | |||
| has_many :products, dependent: :destroy #w zasadzie nie obchodzą nas produkty klienta którego usuwamy z bazy chyba | |||
There was a problem hiding this comment.
dependent wedle uznania 😄
| @@ -0,0 +1,7 @@ | |||
| class Product < ApplicationRecord | |||
| belongs_to :customer, optional: true | |||
| has_many :categories, through: :category_products | |||
There was a problem hiding this comment.
brakuje has_many :category_products do poprawnego działania 😉
| @@ -1,3 +1,6 @@ | |||
| Rails.application.routes.draw do | |||
| # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html | |||
| resources :customers do | |||
| resources :products | |||
There was a problem hiding this comment.
zauważ, że niesprecyzowanie konkretnych akcji(resources :customers, only: :index) powoduje powstanie masy niepotrzebnych i niezaimplementowanych ścieżek:
| @@ -0,0 +1,4 @@ | |||
| class AddEverythingINeed < ActiveRecord::Migration[5.2] | |||
| def change | |||
| end | |||
| class CreateCategoryProducts < ActiveRecord::Migration[5.2] | ||
| def change | ||
| create_table :category_products do |t| | ||
| add_reference :products, :category |
There was a problem hiding this comment.
chcemy, żeby w tabeli category_products znalazły się odniesienia do kategorii i produktów, więc:
t.belongs_to :category, index: true
t.belongs_to :product, index: true| t.datetime "updated_at", null: false | ||
| end | ||
|
|
||
| create_table "category_products", force: :cascade do |t| |
There was a problem hiding this comment.
Ta join table jest tak naprawdę pusta, brakuje category_id i product_id 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coś pomyliłem z asocjacjami i nic mi teraz nie chce działać. ale już nie zdążę nic więcej zrobić raczej więc wysyłam częściowe rozwiązanie.