Zad4 #144
Open
Zad4 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update respository
after second lecture
Classes number 3 compare
lcture 4
Add lecture 5 slides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Przy refactoringu starałem się trzymać zasad SOLID, szczególnie - Single Respobibility Principle oraz Open/Close Principle. Inne zmiany to zgodnie z tym co było na wykładzie: serializer, query object, service object, null object. Dodałem brakującą broń magiczną. Oprócz refactoringu usunąłem kilka drobych błędów. Praca domowa sporo po terminie, ale postanowiłem złożyć formularz na praktyki wakacyjne o których mówiliście, dlatego wrzucam rozwiązanie. Wieczorem dodam również zadanie numer 5, przejrzę je tylko jeszcze w domu. Pozdrawiam. PS: wybaczcie, że załączyłem rekrutacyjne zadanie. Trochę obawiam się mieszać przed PRem w commitach. Dzięki, pozdrawiam.