Add support for BQPrimaryWithCriteriaFilterTranslator.mergeTranslator #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dexamundsen
commented
Feb 3, 2025
•
dexamundsen
commented
- add support for BQPrimaryWithCriteriaFilterTranslator.mergeTranslator. this required adding similar support for other filters that may be nested. Some are implemented and some are marked for followup
- Manual tests (success)
- Unit tests added / updated
- Note - mergeTranslator for some of the filter types are handled in a future PR
dexamundsen
force-pushed
the
dexamundsen/primary
branch
from
5608511 to
4d40315
Compare
dexamundsen
commented
Feb 3, 2025
underlay/src/main/java/bio/terra/tanagra/query/sql/translator/ApiTranslator.java
Outdated
Show resolved
Hide resolved
dexamundsen
force-pushed
the
dexamundsen/primary
branch
from
4d40315 to
a9687a1
Compare
dexamundsen
force-pushed
the
dexamundsen/filters-copy
branch
from
8c81981 to
096e842
Compare
dexamundsen
force-pushed
the
dexamundsen/primary
branch
from
a9687a1 to
4095f8d
Compare
# Conflicts: # underlay/src/main/java/bio/terra/tanagra/query/bigquery/translator/BQApiTranslator.java # underlay/src/main/java/bio/terra/tanagra/query/bigquery/translator/filter/BQPrimaryWithCriteriaFilterTranslator.java # underlay/src/main/java/bio/terra/tanagra/query/sql/translator/ApiTranslator.java
tjennison-work
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.