Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BENCH-5181] Fix range data conversion in requests #1169

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

dexamundsen
Copy link
Contributor

@dexamundsen dexamundsen commented Feb 11, 2025

allele count filter (and other with numbers there) are broken

rc: the range fields are numbers and not bigInt.

fix: check for both before converting to literal

image
    SELECT
        id,
        gene,
        rs_number,
        consequence,
        clinvar_significance,
        protein_change,
        allele_count,
        allele_number,
        allele_frequency,
        T_RCNT_variantPerson_NOHIER 
    FROM
        `vwb-dev-blissful-eggplant-4805.aou_test_data_SC2023Q3R2_011625`.T_ENT_variant 
    WHERE
        (
            id IN (SELECT
                id 
            FROM
                `vwb-dev-blissful-eggplant-4805.aou_test_data_SC2023Q3R2_011625`.T_ESA_variant_gene 
            WHERE
                gene = 'GENE')
        ) 
        AND (
            allele_count BETWEEN 2 AND 490399
        ) 
        AND (
            allele_number BETWEEN 133 AND 490787
        ) 
        AND (
            allele_frequency BETWEEN 3.0E-6 AND 0.9993
        ) 
    ORDER BY
        T_RCNT_variantPerson_NOHIER DESC 
    LIMIT
        10000000

@dexamundsen dexamundsen self-assigned this Feb 11, 2025
@dexamundsen dexamundsen merged commit 0df888a into main Feb 13, 2025
8 checks passed
@dexamundsen dexamundsen deleted the dexamundsen/5181 branch February 13, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants