Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOR-1745] Remove lockfile for dependabot, and spotbugs because we use Sonarcloud. #309

Merged
merged 2 commits into from
Jul 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,6 @@ psql "host=127.0.0.1 sslmode=disable dbname=buffer user=buffer"
Note that you must stop the local postgres first to free the 5432 port.
See [this document](https://cloud.google.com/sql/docs/postgres/connect-admin-proxy) for more details.

### Dependencies
We use [Gradle's dependency locking](https://docs.gradle.org/current/userguide/dependency_locking.html)
to ensure that builds use the same transitive dependencies, so they're reproducible. This means that
adding or updating a dependency requires telling Gradle to save the change. If you're getting errors
that mention "dependency lock state" after changing a dep, you need to do this step.

```sh
./gradlew dependencies --write-locks
```

### Jacoco
We use [Jacoco](https://www.eclemma.org/jacoco/) as code coverage library

Expand Down
3 changes: 0 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ plugins {

id 'com.diffplug.spotless' version '6.16.0'
id 'com.github.ben-manes.versions' version '0.42.0'
id 'com.github.spotbugs' version '5.0.13'
id 'com.google.cloud.tools.jib' version '3.2.1'
id 'de.undercouch.download' version '5.1.0'
id 'org.hidetake.swagger.generator' version '2.19.2'
Expand Down Expand Up @@ -123,7 +122,6 @@ dependencies {
implementation('com.nimbusds:nimbus-jose-jwt:9.25.6')
implementation('io.projectreactor.netty:reactor-netty-http:1.1.12')
implementation('com.fasterxml.jackson:jackson-bom:2.14.2')
spotbugs('org.apache.bcel:bcel:6.6.1')
}
}

Expand All @@ -141,7 +139,6 @@ apply from: "$gradleIncDir/jacoco.gradle"
apply from: "$gradleIncDir/javadoc.gradle"
apply from: "$gradleIncDir/jib.gradle"
apply from: "$gradleIncDir/sonarqube.gradle"
apply from: "$gradleIncDir/spotbugs.gradle"
apply from: "$gradleIncDir/spotless.gradle"
apply from: "$gradleIncDir/swagger-server.gradle"
apply from: "$gradleIncDir/testing.gradle"
Expand Down
Loading
Loading