Switch to writing credentials from secrets for integration tests (WOR-1745). #312
Conversation
|
| @@ -6,7 +6,7 @@ test { | |||
|
|
|||
| import org.gradle.api.tasks.testing.logging.TestExceptionFormat | |||
| // This is the path to the default Google service account for the buffer service to run as. | |||
| def googleCredentialsFile = "${projectDir}/src/test/resources/rendered/sa-account.json" | |||
| def googleCredentialsFile = "${projectDir}/rendered/sa-account.json" | |||
There was a problem hiding this comment.
The write-credentials action is not embedding the credential files within the test directory, which makes it different from what local-dev/render-config.sh does (and what local-dev/run-local.sh expects). However, I don't think that's a big deal, and to limit scope I'm not inclined to change how the service is run locally at this time. At some point we should likely follow the repo standards, which will involve creating a standard set of scripts, and we can unify the experience then.
FWIW, I did verify that rendering credentials and running the service locally (following the directions in the README) does still work.
cahrens
changed the title
cahrens
requested review from
a team,
blakery and
aherbst-broad
and removed request for
a team
As part of WOR-1745, we need to change how the CI pipeline gets the SA credentials so that dependabot is able to run the tests (related PR is https://github.com/broadinstitute/terraform-ap-deployments/pull/1623).